fix: conditionally enable regression methods based on term type and s… #2586
Conversation
…how customized Regression chart button if a single method is available
server/src/termdb.server.init.ts
Outdated
| linear: ({ cohortTermTypes }) => { | ||
| return cohortTermTypes.numeric > 0 // numeric term present and could be used as linear outcome | ||
| }, | ||
| logistic: () => true, // consider both numeric & categorical can be logistic outcome |
There was a problem hiding this comment.
can add 'binary' outcome
| return cohortTermTypes.numeric > 0 // numeric term present and could be used as linear outcome | ||
| }, | ||
| logistic: () => true, // consider both numeric & categorical can be logistic outcome | ||
| cox: ({ cohortTermTypes }) => { |
There was a problem hiding this comment.
can add example, 'time to event'
There was a problem hiding this comment.
not sure what u mean
There was a problem hiding this comment.
can add examples for comments I meant:
I can add them in if you'd like.
linear: ({ cohortTermTypes }) => {
// Check if there is at least one numeric term present, which can be used as a linear outcome
// Example: outcome is a continuous variable.
return cohortTermTypes.numeric > 0;
},
logistic: () => true,
// Allow both numeric and categorical terms to be considered as logistic outcomes
// Example: Predicting whether a patient has a disease (yes/no), where the outcome is a binary variable
},
cox: ({ cohortTermTypes }) => {
// Ensure there is at least one survival or condition term present, which is required for a Cox outcome
// Example: Analyzing the time until a patient relapses after treatment, where the outcome is the time until the event occurs
return (cohortTermTypes.survival || 0) + (cohortTermTypes.condition || 0) > 0;
},
There was a problem hiding this comment.
survival and condition terms are time-to-event variables and can be used as Cox outcome. these are facts outside of our code thus not really explained
client/mass/charts.js
Outdated
| if (availableMethods.length > 1) return obj // more than 1 regression methods. do not modify original obj | ||
| if (availableMethods.length == 1) { | ||
| // has only one method. customized button label and click behavior | ||
| const m = availableMethods[0] |
There was a problem hiding this comment.
I feel in our codebase we should refrain from using alphabets like 'm' to assign values. I understand that it's within the scope of that block but it's in several places in the codebase and searching becomes difficult if used in several scripts.
There was a problem hiding this comment.
making an improvement for this and backend
There was a problem hiding this comment.
done please check again
…how customized Regression chart button if a single method is available
Description
at termdbtest, it shows
Regression Analysisbutton with 3 optionsat mbmeta, it shows
Cox Regressionand directly launches uiat allpharm, Cox option no longer shows
nav CI passes
Checklist
Check each task that has been performed or verified to be not applicable.